fix rules for digits in german#596
Merged
Merged
Conversation
moritz-gross
added
bug
Collaborator
|
Looks good. FYI: I have someone who is working for me that I have tasked to use ranges for these chars. Hopefully he is going to do a PR soon -- it should be an easy project using AI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Me and Codex went through the German localization once again for a few minutes to spot easy fixes.
This one is kinda funny as in English, bold has two meanings as in "brave" or "thick", which doesn't exist in German.
side-question: why is so much of
alphabet.rsin the de tests commented out?